fix: prevents goroutine leak at websocket transport #2167 #2168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for hunting this down! |
|
@StevenACoffman I think we need to release a PATCH ASAP for this. |
|
@frederikhors In the issue, @fletcherist mentions there is another leak that he is working on identifying and fixing, so I would prefer to wait and give him time to do so and then include both in a new point release. |
|
Ok, but I think this is already an important PATCH to release because we don't know how much time he needs. |
2 tasks
StevenACoffman
added a commit
that referenced
this pull request
May 26, 2022
…2209) * Added goroutine leak test for chat example * Improved chat example with proper concurrency * Revert "fix: prevents goroutine leak at websocket transport (#2168)" This reverts commit eef7bfa. * Improved subscription channel usage * Regenerated examples and codegen * Add support for subscription keepalives in websocket client * Update chat example test * if else chain to switch Signed-off-by: Steve Coffman <steve@khanacademy.org> * Revert "Add support for subscription keepalives in websocket client" This reverts commits 64b882c and 670cf22. * Fixed chat example race condition * Fixed chatroom#Messages type Co-authored-by: Steve Coffman <steve@khanacademy.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed memory leak described in #2167
I have: